Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Jersey dependencies #361

Merged
merged 2 commits into from
Jun 14, 2017
Merged

Remove Jersey dependencies #361

merged 2 commits into from
Jun 14, 2017

Conversation

bsideup
Copy link
Member

@bsideup bsideup commented Jun 10, 2017

Since we use Netty, it's pointless to depend on Jersey (comes from docker-java)

@bsideup bsideup requested a review from rnorth June 10, 2017 15:21
@bsideup bsideup added this to the 1.3.1 milestone Jun 10, 2017
@rnorth
Copy link
Member

rnorth commented Jun 11, 2017

This is great 😄
I think I tried this before but didn't think to re-add the jaxrs-api dependency.
👍 !

@rnorth
Copy link
Member

rnorth commented Jun 11, 2017

Ah, just one request - could you update the changelog?

@bsideup
Copy link
Member Author

bsideup commented Jun 11, 2017

@rnorth done :)

@rnorth
Copy link
Member

rnorth commented Jun 13, 2017

Looks like Travis had a wobble - will re-run.

@rnorth
Copy link
Member

rnorth commented Jun 14, 2017

All green so will merge.

@rnorth rnorth merged commit bd228ba into master Jun 14, 2017
@rnorth rnorth deleted the remove_jersey branch June 14, 2017 21:10
bsideup added a commit that referenced this pull request Jun 22, 2017
@bsideup
re #361 put back jersey-common dependency (it's required for docker-m…
0932d5b 
…achine integration)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@bsideup @rnorth