Enable JUnitPlatform for Spock tests
#4568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Spock 2 is based on the JUnit platform, Gradle needs to be configured explicitly to discover and run the tests.
kiview
added
modules/spock
kiview
changed the title
jUnitPlatform for Spock tests
kiview
changed the title
jUnitPlatform for Spock testsJUnitPlatform for Spock tests
bsideup
reviewed
Oct 11, 2021
bsideup
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Dependabot bumped Spock to 2.0 in #4152, our test execution for the Spock module was implicitly disabled. Since Spock 2.0 is based on the JUnit platform, Gradle needs to be configured explicitly to discover and run the tests.
This also has been proven to introduce some unexpected issues to our users before (see https://twitter.com/musketyr/status/1446084194048827397).
While I think it is okay to go ahead using Spock 2.0, it might also be a good idea to document the required change in the Gradle config.