-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make exposeHostPort reusable #6410
Make exposeHostPort reusable #6410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is introducing unnecessary changes. Please, clean it up.
@eddumelendez This should remove the whitespace changes, I added some extra asserts in the test. |
Not exactly sure what's going on yet.
Locally these tests seem to work fine.
|
@eddumelendez I've made the changes you requested. Not sure how to remove the 'changes requested' flag. |
@eddumelendez Any updates on this PR? -We're also running into this issue. Thanks in advance! |
#3457
Container can now start when using withReuse(true) and TestContainers.exposeHostPort(). Simple if check added: if reuse is true don't call connectToPortForwardingNetwork()