-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Yugabyte wait strategy #7599
Conversation
* Changed wait strategy for ysql testcontainer * Updating YugabyteDB-YSQL WaitStrategy * Catch IllegalStateException * Update test query * Changes as per review * Added a test case. * Updating YSQL wait strategy * Removing redundant if. * Minor Change * YugabyteDB version updates in tests
* Changed wait strategy for ysql testcontainer * Updating YugabyteDB-YSQL WaitStrategy * Catch IllegalStateException * Update test query * Changes as per review * Added a test case. * Updating YSQL wait strategy * Removing redundant if. * Minor Change * YugabyteDB version updates in tests
@HarshDaryani896 can you please take a look why test are failing? I think we can consider this one too. Thanks |
@eddumelendez We are working on figuring out the reason of the failure. Meanwhile I figured that if we create a normal table instead of a temp table as part of the YSQL waitStrategy we will not get this failure. I have attached a patch to create and drop a table, instead of creating a temp table in the YSQL waitStrategy. This should resolve the failure. |
Hey @eddumelendez I have created a new branch which has all the required changes including the above patch. Please let me know if you want me to create a new PR or if we can update the current PR. Thanks |
@HarshDaryani896 feel free to raise a PR. I'm planning to include it for the next release. Thanks in advance |
Hey @eddumelendez Thank you for the response. |
Superseded by #7784 |
Update wait strategy by using a temporal table instead of select statement.
Also, make it compatible with version 2.18.