-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix log for Grafana URL #8961
Fix log for Grafana URL #8961
Conversation
When user wants to access Grafana dashboard listening to 3000, this method helps to achieve it easily.
Hi @rajadilipkolli are you planning to interact to Grafana programmatically? Can you tell more about it, please? Asking because that's something I haven't had in mind. |
Hi @eddumelendez , I want to query tempo programatically using below sample and also I want to use LGTMContainer as testcontainers in dev-mode so that I can play in UI given().contentType(ContentType.URLENC)
.body("q={span.http.response.status_code=\"200\"}")
.when()
.post("/api/datasources/proxy/uid/tempo/api/search")
.then()
.statusCode(HttpStatus.SC_OK)
.contentType(ContentType.JSON)
.body("metrics.completedJobs", is(1))
.body("metrics.totalJobs", is(1)); |
Ok, understood! and I just noticed we are logging the url but not for grafana 😢, so we should fix that. Currently, we are not exposing ports for Tempo and Loki, we can add those as well. I didn't include them at the beginning since couldn't built test for those and was looking for feedback from the community. So, your feedback is great! WDYT about fixing the log? and if you have time to add proper validation for Tempo then it would be very much appreciated |
@eddumelendez , just fixed log before your comment. I will work on test cases over the weekend |
Thanks for your contribution, @rajadilipkolli ! |
When user wants to access Grafana dashboard listening to 3000, this method helps to achieve it easily.