feat: support copy files to container (#730) #1151
ci.yml
on: push
Build with MSRV
2m 43s
Rustfmt check
18s
PR name check
0s
Matrix: Clippy check
Matrix: Test
Annotations
24 warnings
Rustfmt check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rustfmt check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rustfmt check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rustfmt check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rustfmt check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rustfmt check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
this expression creates a reference which is immediately dereferenced by the compiler:
testcontainers/src/runners/async_runner.rs#L221
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> testcontainers/src/runners/async_runner.rs:221:51
|
221 | .copy_to_container(&container_id, ©_to_source)
| ^^^^^^^^^^^^^^^ help: change this to: `copy_to_source`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this manual char comparison can be written more succinctly:
testcontainers/src/core/logs/consumer/logging_consumer.rs#L47
warning: this manual char comparison can be written more succinctly
--> testcontainers/src/core/logs/consumer/logging_consumer.rs:47:48
|
47 | let message = message.trim_end_matches(|c| c == '\n' || c == '\r');
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['\n', '\r']`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison
= note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
testcontainers/src/core/copy.rs#L52
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> testcontainers/src/core/copy.rs:52:46
|
52 | ar.append_file(&target_path, &mut f)
| ^^^^^^ help: change this to: `f`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
unneeded `return` statement:
testcontainers/src/core/copy.rs#L30
warning: unneeded `return` statement
--> testcontainers/src/core/copy.rs:30:21
|
30 | None => return Err(CopyToContaienrError::PathNameError(self.target.clone())),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
30 | None => Err(CopyToContaienrError::PathNameError(self.target.clone())),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
doc list item without indentation:
testcontainers/src/core/image/image_ext.rs#L93
warning: doc list item without indentation
--> testcontainers/src/core/image/image_ext.rs:93:9
|
93 | /// If not specified, the daemon default is used, which can either be `\"private\"` or `\"host\"`, depending on daemon version, kerne...
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
= note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
|
93 | /// If not specified, the daemon default is used, which can either be `\"private\"` or `\"host\"`, depending on daemon version, kernel support and configuration.
| ++
|
the borrowed expression implements the required traits:
testimages/build.rs#L27
warning: the borrowed expression implements the required traits
--> testimages/build.rs:27:14
|
27 | .arg(&format!(
| ______________^
28 | | "{cwd}/src/dockerfiles/simple_web_server.dockerfile"
29 | | ))
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
27 ~ .arg(format!(
28 + "{cwd}/src/dockerfiles/simple_web_server.dockerfile"
29 ~ ))
|
|
the borrowed expression implements the required traits:
testimages/build.rs#L12
warning: the borrowed expression implements the required traits
--> testimages/build.rs:12:14
|
12 | .arg(&format!("{cwd}/src/dockerfiles/no_expose_port.dockerfile"))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{cwd}/src/dockerfiles/no_expose_port.dockerfile")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
testcontainers/src/runners/async_runner.rs#L221
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> testcontainers/src/runners/async_runner.rs:221:51
|
221 | .copy_to_container(&container_id, ©_to_source)
| ^^^^^^^^^^^^^^^ help: change this to: `copy_to_source`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this manual char comparison can be written more succinctly:
testcontainers/src/core/logs/consumer/logging_consumer.rs#L47
warning: this manual char comparison can be written more succinctly
--> testcontainers/src/core/logs/consumer/logging_consumer.rs:47:48
|
47 | let message = message.trim_end_matches(|c| c == '\n' || c == '\r');
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['\n', '\r']`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison
= note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
testcontainers/src/core/copy.rs#L52
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> testcontainers/src/core/copy.rs:52:46
|
52 | ar.append_file(&target_path, &mut f)
| ^^^^^^ help: change this to: `f`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
unneeded `return` statement:
testcontainers/src/core/copy.rs#L30
warning: unneeded `return` statement
--> testcontainers/src/core/copy.rs:30:21
|
30 | None => return Err(CopyToContaienrError::PathNameError(self.target.clone())),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
30 | None => Err(CopyToContaienrError::PathNameError(self.target.clone())),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
doc list item without indentation:
testcontainers/src/core/image/image_ext.rs#L93
warning: doc list item without indentation
--> testcontainers/src/core/image/image_ext.rs:93:9
|
93 | /// If not specified, the daemon default is used, which can either be `\"private\"` or `\"host\"`, depending on daemon version, kerne...
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
= note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
|
93 | /// If not specified, the daemon default is used, which can either be `\"private\"` or `\"host\"`, depending on daemon version, kernel support and configuration.
| ++
|
the borrowed expression implements the required traits:
testimages/build.rs#L27
warning: the borrowed expression implements the required traits
--> testimages/build.rs:27:14
|
27 | .arg(&format!(
| ______________^
28 | | "{cwd}/src/dockerfiles/simple_web_server.dockerfile"
29 | | ))
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
27 ~ .arg(format!(
28 + "{cwd}/src/dockerfiles/simple_web_server.dockerfile"
29 ~ ))
|
|
the borrowed expression implements the required traits:
testimages/build.rs#L12
warning: the borrowed expression implements the required traits
--> testimages/build.rs:12:14
|
12 | .arg(&format!("{cwd}/src/dockerfiles/no_expose_port.dockerfile"))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{cwd}/src/dockerfiles/no_expose_port.dockerfile")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
Clippy check (nightly)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Clippy check (nightly)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Clippy check (stable)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Clippy check (stable)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|