feat: add working_dir to ContainerRequest,ImageExt
#724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-rust ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
DDtKey
approved these changes
Aug 25, 2024
DDtKey
approved these changes
Aug 25, 2024
This was referenced Aug 26, 2024
Merged
DDtKey
pushed a commit
that referenced
this pull request
Aug 30, 2024
## 🤖 New release * `testcontainers`: 0.21.1 -> 0.22.0 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.22.0] - 2024-08-30 ### Details #### Bug Fixes - [❗] Docker socket detection on unix ([#721](#721)) #### Features - Add `working_dir` to `ContainerRequest`,`ImageExt` ([#724](#724)) #### Miscellaneous Tasks - Added `#![forbid(unsafe_code)]` to the library ([#722](#722)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #720 by adding support for setting the working directory on
ImageExtandContainerRequest. Also adds a test for this feature. This is equivalent to the-w, --workdirflag ofdocker run.The abbreviation
working_dir(as opposed to e.g.working_directory) was chosen to use the same name as thebollardcrate.