Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for user-configured labels #756

Merged
merged 5 commits into from
Dec 6, 2024

Conversation

the-wondersmith
Copy link
Contributor

PR adds support for applying user-configured labels to containers started by testcontainers.

Note

This PR is a precursor to future support of reusable containers

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for testcontainers-rust ready!

Name Link
🔨 Latest commit 5bc6d1e
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-rust/deploys/67524c291bb06f0008795c05
😎 Deploy Preview https://deploy-preview-756--testcontainers-rust.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@DDtKey DDtKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot for the contribution! 🙏

I find this pretty small and simple PR looking good to me, just a few comments to discuss and LGTM! ✅

testcontainers/src/core/image/image_ext.rs Outdated Show resolved Hide resolved
testcontainers/src/runners/async_runner.rs Outdated Show resolved Hide resolved
@the-wondersmith
Copy link
Contributor Author

Thank you a lot for the contribution! 🙏

Absolutely my pleasure 😁

I find this pretty small and simple PR looking good to me, just a few comments to discuss and LGTM! ✅

I replied to both comments, and pushed the suggested changes. If the responses (and changes) make sense and to you look good, I'll leave the Resolve Conversation button to your discretion 😅

@DDtKey
Copy link
Collaborator

DDtKey commented Dec 6, 2024

Perfect, LGTM ✅

I'll take a look at the second PR soon, thanks one more time! ❤️

@DDtKey DDtKey enabled auto-merge (squash) December 6, 2024 02:07
@DDtKey DDtKey merged commit 2756f68 into testcontainers:main Dec 6, 2024
12 checks passed
@the-wondersmith the-wondersmith deleted the feat/container-labels branch December 6, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants