feat(waitForElementToBeRemoved): support passing an element directly #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6fe2000:
|
Codecov Report
@@ Coverage Diff @@
## beta #460 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 412 419 +7
Branches 98 100 +2
=========================================
+ Hits 412 419 +7 Continue to review full report at Codecov.
|
|
Feel free to comment later if you have questions or feedback. We can address them before we publish beta. |
|
🎉 This PR is included in version 7.0.0-beta.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
kentcdodds
added a commit
that referenced
this pull request
Mar 4, 2020
kentcdodds
added a commit
that referenced
this pull request
Mar 4, 2020
kentcdodds
added a commit
that referenced
this pull request
Mar 12, 2020
kentcdodds
added a commit
that referenced
this pull request
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: feat(waitForElementToBeRemoved): support passing an element directly
Why: Makes using this async utility simpler
How: Overload the argument for this so the callback can be a DOM node (or array of DOM nodes). In that case, we capture those and reassign the callback to a function that checks whether those are still contained in their original parent element
Checklist:
Really excited about this one.