-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rules): added rule for prefer-to-have-class #118
Conversation
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 14 +1
Lines 259 312 +53
Branches 37 42 +5
=========================================
+ Hits 259 312 +53
Continue to review full report at Codecov.
|
@AntonNiklasson mind giving this a once over? if you think of any additional use cases let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor things. Also, did you consider supporting something like el.classList.contains('foo')
here?
Co-authored-by: Anton Niklasson <[email protected]>
🎉 This PR is included in version 3.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What: a new rule for prefer-to-have-class
Why: all the matchers!
How:
Checklist: