Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tracing for federated exemplar API #4130

Closed
yeya24 opened this issue Apr 30, 2021 · 4 comments · Fixed by #4299
Closed

Add tracing for federated exemplar API #4130

yeya24 opened this issue Apr 30, 2021 · 4 comments · Fixed by #4299
Labels
component: query difficulty: easy good first issue help wanted

Comments

@yeya24
Copy link
Contributor

yeya24 commented Apr 30, 2021

Describe the solution you'd like

Instrument tracing spans for the federated APIs. This should include the proxy (querier) side as well as the leaf store sides.
@yeya24 yeya24 changed the title Add tracing span for federated exemplar API Add tracing for federated exemplar API Apr 30, 2021
@Hangzhi
Copy link
Contributor

Hangzhi commented May 4, 2021

May I work on this?

@yeya24
Copy link
Contributor Author

yeya24 commented May 4, 2021

Sure, feel free to take it. @Hangzhi

@bill3tt
Copy link
Contributor

bill3tt commented Jun 2, 2021

Hey @Hangzhi 👋 - are you working on this? I can't see any active branches or forks. If not - I'm happy to take this on.

@Hangzhi
Copy link
Contributor

Hangzhi commented Jun 3, 2021

@ianbillett Please take this on! Sorry for leaving this inactive.

@bill3tt bill3tt mentioned this issue Jun 3, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: query difficulty: easy good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tracing to exemplar APIs bill3tt/thanos
3 participants
@yeya24 @Hangzhi @bill3tt