Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query: Optimizations for 100+ stores #751

Closed
bwplotka opened this issue Jan 21, 2019 · 1 comment
Closed

query: Optimizations for 100+ stores #751

bwplotka opened this issue Jan 21, 2019 · 1 comment

Comments

@bwplotka
Copy link
Member

No one had use case like this, also it easy to mitigate with intermediate Thanos queriers, but we might get into issue while asking so many stores.

Acceptance criteria:

  • Benchmark before and after
  • We can control / limit memory consumption for case of 100+ stores.

Some idea: manage pool of go routines for gRPC stream instead of having each for 100+ stores with constant (1) channel buffer each)

@stale
Copy link

stale bot commented Jan 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 11, 2020
@stale stale bot closed this as completed Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant