Testing and reports #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ox-baloo
reviewed
May 17, 2020
|
|
||
| # Folder within the ONS Postcode Directory archive holding names and codes files | ||
| names_codes_root = DATA_ROOT / self.settings["ONS Names and codes folder"] |
There was a problem hiding this comment.
did you mean to remove DATA_ROOT?
There was a problem hiding this comment.
Yes I think so as data/ is in settings.json already https://github.com/the-scouts/geo_mapping/blob/4c6484d041d7a1ebc0fca964d714b68504d80faf/settings.json#L5-L6
|
|
||
| # Folder within the ONS Postcode Directory archive holding names and codes files | ||
| names_codes_root = DATA_ROOT / Path(self.settings["ONS Names and codes folder"]).resolve() |
There was a problem hiding this comment.
did you mean to remove DATA_ROOT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of things in this one
Move testing to parameterised using hypothesis. Shouldn't be any noticable difference, but this will be helpful for identifying edge cases etc as we move forwards (and increase test coverage!)
Add functionality relating to Clear workflow for supporting custom shapefiles #51. I'm still not happy with this as (1) it requires regenerating both the merged census extract and the reduced ONS file, and (2) it doesn't preserve population sizes etc. (2) is an easier fix, for (1) the ideal is to dynamically hook in without any pre-setup etc.
WIP for now as not ready for merging