Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define required_ruby_version #867

Merged
merged 1 commit into from
Jan 22, 2024
Merged

define required_ruby_version #867

merged 1 commit into from
Jan 22, 2024

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Jan 22, 2024

No description provided.

foreman_rh_cloud.gemspec Outdated Show resolved Hide resolved
@ekohl
Copy link
Member

ekohl commented Jan 22, 2024

Also, the target Ruby version needs to match. Looks like the config is pinned to Foreman 2.3 even though this branch is for Foreman 3.9.
https://github.com/theforeman/foreman_rh_cloud/blob/ebcbeed9d6707fa2760c14490ee8824e25ef2d7b/.rubocop.yml

@evgeni
Copy link
Member Author

evgeni commented Jan 22, 2024

Also, the target Ruby version needs to match. Looks like the config is pinned to Foreman 2.3 even though this branch is for Foreman 3.9. https://github.com/theforeman/foreman_rh_cloud/blob/ebcbeed9d6707fa2760c14490ee8824e25ef2d7b/.rubocop.yml

I wanted to tackle that once the first round of auto-fixes is in ;-)

@ekohl
Copy link
Member

ekohl commented Jan 22, 2024

I mostly mention it because #866 fails on it.

@evgeni
Copy link
Member Author

evgeni commented Jan 22, 2024

hmm, given it takes the TargetRubyVersion from theforeman-rubocop… shall we set it to 2.5+ for now, or add it to rubocop_todo to fix properly?

@evgeni evgeni merged commit 5236322 into foreman_3_9 Jan 22, 2024
3 checks passed
@evgeni evgeni deleted the required-ruby branch January 22, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants