Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the net-http spy usable #2

Closed
timogoebel opened this issue May 2, 2019 · 0 comments · Fixed by #7
Closed

make the net-http spy usable #2

timogoebel opened this issue May 2, 2019 · 0 comments · Fixed by #7
Labels
enhancement New feature or request

Comments

@timogoebel
Copy link
Member

We currently disable the net-http spy:
https://github.com/timogoebel/foreman_supervisory_authority/blob/95c7dcd7b041597b3351ed437c79e8d80fbf5745/lib/foreman_supervisory_authority/engine.rb#L17-L20

This is because Foreman extends net/http using Module.prepend:

https://github.com/theforeman/foreman/blob/84ae69c6bf191837e8c7b4ccadb4583eebeda172/lib/foreman/http_proxy/net_http_extension.rb#L20-L23

And the elastic APM uses alias_method, which conflicts.

Elastic-APM Issue: elastic/apm-agent-ruby#379
@timogoebel timogoebel added the enhancement New feature or request label May 2, 2019
@timogoebel timogoebel changed the title allow to activate the net-http spy make the net-http spy usable May 2, 2019
@laugmanuel laugmanuel mentioned this issue May 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump ElasticAPM Agent to ~> 4.0.0
1 participant
@timogoebel