Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KNN imputation improvements #307

Closed
Zethson opened this issue Feb 11, 2022 · 0 comments · Fixed by #365
Closed

KNN imputation improvements #307

Zethson opened this issue Feb 11, 2022 · 0 comments · Fixed by #365
Assignees
@Imipenem
Labels
enhancement New feature or request

Comments

@Zethson
Copy link
Member

Zethson commented Feb 11, 2022 •
edited
Loading

  1. Ensure that value K is accessible for numerical and ideally also categorical values
  2. Try to find some strategy to impute categorical values with e.g. most frequent -> explore scanpy KNN (neighbors) for custom implementation if required. Likely will involve label encoding the values, imputing and then mapping back.
  3. Google around for KNN imputation improvements
@Zethson Zethson added the enhancement New feature or request label Feb 11, 2022
@Zethson Zethson added this to the 0.2 milestone Feb 11, 2022
Imipenem added a commit that referenced this issue Mar 29, 2022
@Imipenem
[#307] Improve KNN with n_neighbours parameter
0215949 
- added n_neighbours parameter to knn impute

- encoding now only gets applied to non numerical columns

- added tests for knn impute with n_neighbours parameter
@Imipenem Imipenem linked a pull request Mar 29, 2022 that will close this issue
[#307] Improve KNN with n_neighbours parameter #365
Merged
4 tasks
Imipenem added a commit that referenced this issue Mar 29, 2022
@Imipenem
Merge pull request #365 from theislab/feature/improve_knn
71d21db 
[#307] Improve KNN with n_neighbours parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Imipenem Imipenem

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#307] Improve KNN with n_neighbours parameter theislab/ehrapy
2 participants
@Zethson @Imipenem