Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/deep translator integration #303

Merged
merged 5 commits into from
Feb 8, 2022

Conversation

MxMstrmn
Copy link
Contributor

@MxMstrmn MxMstrmn commented Feb 7, 2022

PR Checklist

  • This comment contains a description of changes (with reason)
  • Referenced issue is linked
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes
This PR introduces a additional translatros to be used with the Translator superclass. Check the new falvours for "libre", "mymemory", "microsoft", "yandex" translators. Note that keys are required for "yandex" and "microsoft" and that these are currently skipped in tests. The other two have quite strict limits on the number of requets /minute and/or /day. This them unsuitable for proper usage at this stage. Thay are working though.

Some translators like "pons" or "linguee" only translate individual words and are not supported. Also, the "qcri" translator mainly support arabic which might not be relevant at this point in time and is excluded here.

For testing the check of available tokens has been further abstracted.

Technical details
Adresses #115 and ticks the checkpoint on Implement all other translators.

Additional context

@github-actions github-actions bot added the enhancement New feature or request label Feb 7, 2022
@Zethson Zethson linked an issue Feb 8, 2022 that may be closed by this pull request
8 tasks
@Zethson Zethson merged commit c3163f1 into development Feb 8, 2022
@Zethson Zethson deleted the feature/deep_translator_integration branch February 25, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation services beyond DeepL and unified API
2 participants