Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Synchronous dataloader write #722

Merged
merged 2 commits into from
May 9, 2024
Merged

Enable Synchronous dataloader write #722

merged 2 commits into from
May 9, 2024

Conversation

wxicu
Copy link
Collaborator

@wxicu wxicu commented May 8, 2024

PR Checklist

  • This comment contains a description of changes (with reason)
  • Referenced issue is linked
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes
Enable Synchronous dataloader write with a file lock.

Technical details

Additional context

Zethson
Zethson approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank youu!

@Zethson Zethson merged commit 9f7bd8d into main May 9, 2024
16 of 17 checks passed
@Zethson Zethson deleted the filelock branch June 3, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zethson Zethson Zethson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wxicu @Zethson