Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs error handling if curl calls fail #21

Open
william-richard opened this issue Jan 14, 2020 · 0 comments
Open

Needs error handling if curl calls fail #21

william-richard opened this issue Jan 14, 2020 · 0 comments

Comments

@william-richard
Copy link

Hi,

We've been using this package for a while, and noticed that it will not raise any errors of the github API calls fail.

This is especially difficult to address because the code ultimately shells out to curl - the --fail flag could be used, but then curl would not report the error message github encountered.

I think the best way to address this would be to switch from using curl to making the HTTP call in code, and then checking the error code.

Sadly, I don't really know javascript - I would be happy to help, but I'm not entirely sure how to implement even something as simple as an HTTP GET.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant