forked from rectorphp/rector-phpunit
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathExceptionAnnotationRector.php
123 lines (107 loc) · 3.6 KB
/
ExceptionAnnotationRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
<?php
declare(strict_types=1);
namespace Rector\PHPUnit\PHPUnit60\Rector\ClassMethod;
use PhpParser\Node;
use PhpParser\Node\Stmt\ClassMethod;
use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfo;
use Rector\BetterPhpDocParser\PhpDocManipulator\PhpDocTagRemover;
use Rector\Comments\NodeDocBlock\DocBlockUpdater;
use Rector\Core\Rector\AbstractRector;
use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
use Rector\PHPUnit\NodeFactory\ExpectExceptionMethodCallFactory;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @changelog https://thephp.cc/news/2016/02/questioning-phpunit-best-practices
* @changelog https://github.com/sebastianbergmann/phpunit/commit/17c09b33ac5d9cad1459ace0ae7b1f942d1e9afd
*
* @see \Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\ExceptionAnnotationRector\ExceptionAnnotationRectorTest
*/
final class ExceptionAnnotationRector extends AbstractRector
{
/**
* In reversed order, which they should be called in code.
*
* @var array<string, string>
*/
private const ANNOTATION_TO_METHOD = [
'expectedExceptionMessageRegExp' => 'expectExceptionMessageRegExp',
'expectedExceptionMessage' => 'expectExceptionMessage',
'expectedExceptionCode' => 'expectExceptionCode',
'expectedException' => 'expectException',
];
public function __construct(
private readonly ExpectExceptionMethodCallFactory $expectExceptionMethodCallFactory,
private readonly PhpDocTagRemover $phpDocTagRemover,
private readonly TestsNodeAnalyzer $testsNodeAnalyzer,
private readonly DocBlockUpdater $docBlockUpdater,
) {
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(
'Changes `@expectedException annotations to `expectException*()` methods',
[
new CodeSample(
<<<'CODE_SAMPLE'
/**
* @expectedException Exception
* @expectedExceptionMessage Message
*/
public function test()
{
// tested code
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
public function test()
{
$this->expectException('Exception');
$this->expectExceptionMessage('Message');
// tested code
}
CODE_SAMPLE
),
]
);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [ClassMethod::class];
}
/**
* @param ClassMethod $node
*/
public function refactor(Node $node): ?Node
{
if (! $this->testsNodeAnalyzer->isInTestClass($node)) {
return null;
}
$phpDocInfo = $this->phpDocInfoFactory->createFromNode($node);
if (! $phpDocInfo instanceof PhpDocInfo) {
return null;
}
$hasChanged = false;
foreach (self::ANNOTATION_TO_METHOD as $annotationName => $methodName) {
if (! $phpDocInfo->hasByName($annotationName)) {
continue;
}
$methodCallExpressions = $this->expectExceptionMethodCallFactory->createFromTagValueNodes(
$phpDocInfo->getTagsByName($annotationName),
$methodName,
);
$node->stmts = array_merge($methodCallExpressions, (array) $node->stmts);
$this->phpDocTagRemover->removeByName($phpDocInfo, $annotationName);
$hasChanged = true;
}
if (! $hasChanged) {
return null;
}
$this->docBlockUpdater->updateRefactoredNodeWithPhpDocInfo($node);
return $node;
}
}