-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working in IE #20
Comments
Which IE version have you tried ? |
I tried on IE11. Just in case, here are the polyfills I imported for IE (in polyfills.ts) : |
Ok tks, actually I have not tried using this with IE. Will give it a try and I will try to make it work on IE11 and above. Tks for reporting ! |
Alright thank you ;) For the time being, I'm using lightbox2 although I'd prefer your library because it's more "angular-friendly". |
I'm having the same issue. It breaks in lightbox.component.ts in _sizeContainer() method. The IE doesn't seem to support the transition. Therefore, _postResize() method doesn't get called at all. I don't know a good fix but my current work-around is to call _postResize method after a second or two using setTimeout() to ensure it gets called in IE. Do you guys have any thoughts? |
I guess the call back of those transitionend not being called for some reason. PR welcome if u know how to fix it. |
Hi mate, I've sent the pull request. Apparently, it was some CSS properties for the transition and animation that caused this issue. |
Hi, tks for your help. Really appreciate it. Have you tested on IE 10 and 11, work fine ? Cuz I dont use windows. |
I've tested it on IE 11 and it works fine. Although I haven't tested this in IE 10, animation-duration and transition-duration are said to be supported in IE 10.0 and above in w3schools. So, it should be fine. |
@themyth92 Can you please create a new release (in npm)? |
Well if https://themyth92.com/project/angular2-lightbox/ is up to date, then I confirm it now works on IE11 ;) I think it can be closed (if it works on IE11, there's no reason it cannot work in IE10). Good job ;-D |
Hi,
I don't know if it's a known problem and if there's already a fix for that but if you tried to run the demo on Chrome : it works :D (the image is indeed displaying).
But in Internet Explorer, the image is not displaying :(
I'm working in a project with Angular4 FYI.
Best regards,
skype007
The text was updated successfully, but these errors were encountered: