From 6106a1fe9b57eafca9cde2e69d4ed20e9364ec43 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Th=C3=A9o=20FIDRY?= <5175937+theofidry@users.noreply.github.com> Date: Thu, 8 Dec 2022 00:50:13 +0100 Subject: [PATCH] Simplify some tests (#68) --- tests/Finder/CpuInfoFinderTest.php | 5 +++++ tests/Finder/HwLogicalFinderTest.php | 4 +--- tests/Finder/HwPhysicalFinderTest.php | 4 +--- tests/Finder/WindowsWmicLogicalFinderTest.php | 4 +--- tests/Finder/WindowsWmicPhysicalFinderTest.php | 4 +--- 5 files changed, 9 insertions(+), 12 deletions(-) diff --git a/tests/Finder/CpuInfoFinderTest.php b/tests/Finder/CpuInfoFinderTest.php index d8391d4..ecb4550 100644 --- a/tests/Finder/CpuInfoFinderTest.php +++ b/tests/Finder/CpuInfoFinderTest.php @@ -33,6 +33,11 @@ protected function setUp(): void $this->finder = new CpuInfoFinder(); } + protected function tearDown(): void + { + unset($this->finder); + } + public function test_it_can_describe_itself(): void { self::assertSame('CpuInfoFinder', $this->finder->toString()); diff --git a/tests/Finder/HwLogicalFinderTest.php b/tests/Finder/HwLogicalFinderTest.php index 9278957..a690ab2 100644 --- a/tests/Finder/HwLogicalFinderTest.php +++ b/tests/Finder/HwLogicalFinderTest.php @@ -25,9 +25,7 @@ final class HwLogicalFinderTest extends PopenBasedFinderTestCase { public function test_it_can_describe_itself(): void { - $finder = new HwLogicalFinder(); - - self::assertSame('HwLogicalFinder', $finder->toString()); + self::assertSame('HwLogicalFinder', $this->getFinder()->toString()); } protected function getFinder(): PopenBasedFinder diff --git a/tests/Finder/HwPhysicalFinderTest.php b/tests/Finder/HwPhysicalFinderTest.php index 72d6057..8bd0745 100644 --- a/tests/Finder/HwPhysicalFinderTest.php +++ b/tests/Finder/HwPhysicalFinderTest.php @@ -25,9 +25,7 @@ final class HwPhysicalFinderTest extends PopenBasedFinderTestCase { public function test_it_can_describe_itself(): void { - $finder = new HwPhysicalFinder(); - - self::assertSame('HwPhysicalFinder', $finder->toString()); + self::assertSame('HwPhysicalFinder', $this->getFinder()->toString()); } protected function getFinder(): PopenBasedFinder diff --git a/tests/Finder/WindowsWmicLogicalFinderTest.php b/tests/Finder/WindowsWmicLogicalFinderTest.php index 14ef2ff..ac108f6 100644 --- a/tests/Finder/WindowsWmicLogicalFinderTest.php +++ b/tests/Finder/WindowsWmicLogicalFinderTest.php @@ -25,9 +25,7 @@ final class WindowsWmicLogicalFinderTest extends PopenBasedFinderTestCase { public function test_it_can_describe_itself(): void { - $finder = new WindowsWmicLogicalFinder(); - - self::assertSame('WindowsWmicLogicalFinder', $finder->toString()); + self::assertSame('WindowsWmicLogicalFinder', $this->getFinder()->toString()); } protected function getFinder(): PopenBasedFinder diff --git a/tests/Finder/WindowsWmicPhysicalFinderTest.php b/tests/Finder/WindowsWmicPhysicalFinderTest.php index 106c12e..dd74182 100644 --- a/tests/Finder/WindowsWmicPhysicalFinderTest.php +++ b/tests/Finder/WindowsWmicPhysicalFinderTest.php @@ -25,9 +25,7 @@ final class WindowsWmicPhysicalFinderTest extends PopenBasedFinderTestCase { public function test_it_can_describe_itself(): void { - $finder = new WindowsWmicPhysicalFinder(); - - self::assertSame('WindowsWmicPhysicalFinder', $finder->toString()); + self::assertSame('WindowsWmicPhysicalFinder', $this->getFinder()->toString()); } protected function getFinder(): PopenBasedFinder