From 956c039258e3ed44747c8d97f5132e3e9a6d6765 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maxime=20H=C3=A9lias?= Date: Thu, 2 Nov 2023 13:51:38 +0100 Subject: [PATCH] feat: add default value visibility for directories --- src/Adapter/AdapterDefinitionFactory.php | 2 +- tests/Adapter/AdapterDefinitionFactoryTest.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Adapter/AdapterDefinitionFactory.php b/src/Adapter/AdapterDefinitionFactory.php index f5c8d4f..809c263 100644 --- a/src/Adapter/AdapterDefinitionFactory.php +++ b/src/Adapter/AdapterDefinitionFactory.php @@ -40,7 +40,7 @@ public function __construct() ]; } - public function createDefinition(string $name, array $options, ?string $defaultVisibilityForDirectories): ?Definition + public function createDefinition(string $name, array $options, ?string $defaultVisibilityForDirectories = null): ?Definition { foreach ($this->builders as $builder) { if ($builder->getName() === $name) { diff --git a/tests/Adapter/AdapterDefinitionFactoryTest.php b/tests/Adapter/AdapterDefinitionFactoryTest.php index 44cd4a7..dc7d531 100644 --- a/tests/Adapter/AdapterDefinitionFactoryTest.php +++ b/tests/Adapter/AdapterDefinitionFactoryTest.php @@ -34,7 +34,7 @@ public function testCreateDefinition($name, $options) { $factory = new AdapterDefinitionFactory(); - $definition = $factory->createDefinition($name, $options, null); + $definition = $factory->createDefinition($name, $options); $this->assertInstanceOf(Definition::class, $definition); } }