Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdapterDefinitionFactory::createDefinition() breaking change #155

Closed
stefan1144 opened this issue Nov 2, 2023 · 1 comment · Fixed by #156
Closed

AdapterDefinitionFactory::createDefinition() breaking change #155

stefan1144 opened this issue Nov 2, 2023 · 1 comment · Fixed by #156

Comments

@stefan1144
Copy link

Q A
Version 3.18.0

The BC was introduced in this version in the League\FlysystemBundle\Adapter\AdapterDefinitionFactory , createDefinition method.
?string $defaultVisibilityForDirectories has been added as the last argument, however there is no value set by default (null, per example).

Although class is marked as “internal” it is quite useful, we are using it, and adding third optional parameter could have default value.
Thanks.

@stefan1144
Copy link
Author

Thank you very much for such a quick response and solve!

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants