You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the #1582 PR, the rootLocation property of local adapter was removed and replaced by $this->prefixer->prefixPath('/') to get the root path inside ensureRootDirectoryExists . This is bad, because when using a "fake" / root on Windows (to get access to all disks with a unique filesystem instance), the prefixPath method will return an empty string.
Proposition
I think you should restore the rootLocation property on the class and use it inside the ensureRootDirectoryExists method.
How to reproduce
Configure a local adapter on windows with a / root path. Ensure root directory exists will crash.
The text was updated successfully, but these errors were encountered:
Bug Report
Summary
With the #1582 PR, the
rootLocation
property of local adapter was removed and replaced by$this->prefixer->prefixPath('/')
to get the root path insideensureRootDirectoryExists
. This is bad, because when using a "fake"/
root on Windows (to get access to all disks with a unique filesystem instance), theprefixPath
method will return an empty string.Proposition
I think you should restore the
rootLocation
property on the class and use it inside theensureRootDirectoryExists
method.How to reproduce
Configure a local adapter on windows with a
/
root path. Ensure root directory exists will crash.The text was updated successfully, but these errors were encountered: