Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for async_channel #916

Closed
6 tasks
amab8901 opened this issue Apr 1, 2023 · 1 comment
Closed
6 tasks

Add tests for async_channel #916

amab8901 opened this issue Apr 1, 2023 · 1 comment

Comments

@amab8901
Copy link
Contributor

amab8901 commented Apr 1, 2023

(follow-up on #837)

This addresses the last check on: #715

The following scenarios should be tested:

  • the clone method on Sender/Receiver
  • dropping a Sender or Receiver when multiple ones exist already, rather than just a single one.
  • Trying to send to or receive from a disconnected channel
  • Whether the Receiver::sender() and Sender::receiver() methods properly change the Channel's state in the case of multiple endpoints or a single endpoint.
  • Actually recovering from a channel disconnection using the above methods and then successfully sending and/or receiving through the channel
  • Anything with more than two tasks -- a common use case would be to have several sending tasks and several receiving tasks, so we want to test whether that works properly.

But first, I think we need to identify every scenario that should be tested, so that we aren't missing anything

@kevinaboos
Copy link
Member

Logistics comment: rather than opening up duplicate issues, can you merge them into one? Might as well add these checkbox bullet points to #715.

@amab8901 amab8901 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants