Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support override variables #63

Merged
merged 12 commits into from
Sep 8, 2017
Merged

Support override variables #63

merged 12 commits into from
Sep 8, 2017

Conversation

milonimrod
Copy link
Contributor

@milonimrod milonimrod commented Aug 21, 2017

This is a PR for #5 .
The current open item is that I didn't add the functionality into the ipython support

@coveralls
Copy link

coveralls commented Aug 21, 2017

Coverage Status

Coverage increased (+0.2%) to 82.609% when pulling 8d94c30 on milonimrod:support_override_variables into 5e839d4 on theskumar:master.

@coveralls
Copy link

coveralls commented Aug 21, 2017

Coverage Status

Coverage increased (+0.2%) to 82.609% when pulling ee6bde5 on milonimrod:support_override_variables into 5e839d4 on theskumar:master.

@coveralls
Copy link

coveralls commented Aug 21, 2017

Coverage Status

Coverage increased (+0.4%) to 82.813% when pulling d4f3243 on milonimrod:support_override_variables into 5e839d4 on theskumar:master.

@coveralls
Copy link

coveralls commented Aug 22, 2017

Coverage Status

Coverage increased (+3.5%) to 85.938% when pulling 249cbdd on milonimrod:support_override_variables into 5e839d4 on theskumar:master.

@milonimrod
Copy link
Contributor Author

milonimrod commented Aug 22, 2017

Please notice that on commit 249cbdd I added a general case test for the IPython magic (regardless of the override option)

@theskumar
Copy link
Owner

Thanks for pull request. I'll take a look.

@coveralls
Copy link

coveralls commented Aug 23, 2017

Coverage Status

Coverage increased (+3.5%) to 86.01% when pulling 41bbd1a on milonimrod:support_override_variables into 3aa526c on theskumar:master.

@theskumar
Copy link
Owner

This looks super good feature to go in. IPython support with override -o argument needs to be documented. Happy to merge and release a new build with updated docs. 👍

@theskumar
Copy link
Owner

I've also resolved a merge conflict with web UI for this branch/PR, but not sure how Github would reflect that on your side. If you face any problem let me know, i'll update the docs on my end.

@milonimrod
Copy link
Contributor Author

No problem. I'll pull the new master, merge them and add the documentation (also, I'll add the support for the verbose on the IPython side)

@coveralls
Copy link

coveralls commented Aug 23, 2017

Coverage Status

Coverage increased (+3.6%) to 86.082% when pulling edc4131 on milonimrod:support_override_variables into 3aa526c on theskumar:master.

@milonimrod
Copy link
Contributor Author

milonimrod commented Aug 23, 2017

@theskumar - all done Added:

  1. Fixed a small bug in the Makefile
  2. verbose to Ipython
  3. Added documentation

@coveralls
Copy link

coveralls commented Aug 23, 2017

Coverage Status

Coverage increased (+3.6%) to 86.082% when pulling e2131be on milonimrod:support_override_variables into 3aa526c on theskumar:master.

@theskumar theskumar merged commit 3d84003 into theskumar:master Sep 8, 2017
@theskumar
Copy link
Owner

I've pushed new release, 0.7.0 is now available with this change 🎉. Thanks :)

@milonimrod
Copy link
Contributor Author

@theskumar you are welcome. Just a small request: in the Readme file you mentioned the pull request with a different username instead of mine.

@theskumar
Copy link
Owner

Readme fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants