Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not ioutil.ReadAll anything without limiting the size. #1186

Merged
merged 1 commit into from
Jul 10, 2017
Merged

Do not ioutil.ReadAll anything without limiting the size. #1186

merged 1 commit into from
Jul 10, 2017

Conversation

cyli
Copy link
Contributor

@cyli cyli commented Jul 8, 2017

Fixed some of the httpstore downloading logic to limit the size of the response bodies we're willing to read.

We should also fix ImportKeys and the notary verify command, but those are slightly bigger changes, so am splitting them out.

@cyli cyli force-pushed the limit-readall-size branch from 6ebd284 to 2c18c0e Compare July 8, 2017 00:32
riyazdf
riyazdf approved these changes Jul 8, 2017
View reviewed changes
Copy link
Contributor

@riyazdf riyazdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, LGTM on green!

@endophage endophage merged commit 87d6d6c into notaryproject:master Jul 10, 2017
@cyli cyli deleted the limit-readall-size branch July 11, 2017 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riyazdf riyazdf riyazdf approved these changes

@endophage endophage endophage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyli @endophage @riyazdf