Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed the scorecard badge link to the standard format #2665

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

harshitasao
Copy link
Contributor

Description of the changes being introduced by the pull request:

Changes the scorecard badge link from old format to the Standard human-readable OpenSSF Scorecard Report.

@coveralls
Copy link

coveralls commented Jul 4, 2024

Pull Request Test Coverage Report for Build 9799641311

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.805%

Totals Coverage Status
Change from base Build 9657681730: 0.0%
Covered Lines: 1554
Relevant Lines: 1591

💛 - Coveralls

Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

README.md Outdated
@@ -5,7 +5,7 @@
[![Docs](https://readthedocs.org/projects/theupdateframework/badge/)](https://theupdateframework.readthedocs.io/)
[![CII](https://bestpractices.coreinfrastructure.org/projects/1351/badge)](https://bestpractices.coreinfrastructure.org/projects/1351)
[![PyPI](https://img.shields.io/pypi/v/tuf)](https://pypi.org/project/tuf/)
[![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/theupdateframework/python-tuf/badge)](https://api.securityscorecards.dev/projects/github.com/theupdateframework/python-tuf)
[![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/theupdateframework/python-tuf/badge)](https://scorecard.dev/viewer/?uri=github.com/theupdateframework/python-tuf)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the scorecards domain changed. It used to be securityscorecards.dev (and that's still linked to from openssf.org), but the project's README points to scorecard.dev

scorecard.dev is the "correct" domain.

Signed-off-by: Jussi Kukkonen <[email protected]>
@jku
Copy link
Member

jku commented Jul 9, 2024

yeah, that looks a lot better, thanks.

We should update the badge url as well though to be consistent. I can add that change since your branch allows it, just a sec...

@jku
Copy link
Member

jku commented Jul 9, 2024

I don't understand why the CI is not running. I'll try closing and reopening to trigger a run

@jku jku closed this Jul 9, 2024
@jku jku reopened this Jul 9, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9858345314

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.805%

Totals Coverage Status
Change from base Build 9852024133: 0.0%
Covered Lines: 1554
Relevant Lines: 1591

💛 - Coveralls

@jku jku merged commit 3947033 into theupdateframework:develop Jul 9, 2024
15 checks passed
@jku
Copy link
Member

jku commented Jul 9, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants