-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a conformance test workflow #2670
Conversation
jku
commented
Jul 10, 2024
- The conformance test suite is likely to still change quite a bit so the workflow is not enabled on PRs yet (and does not pin the action version)
- The actual conformance client is copied from the tuf-conformance project
- This is mostly a test to see how things should work out, and a demonstration of how the tuf-conformance project should be used
* The conformance test suite is likely to still change quite a bit so the workflow is not enabled on PRs yet * The actual conformance client is copied from the tuf-conformance project * This is mostly a test to see how things should work out, and a demonstration of how the tuf-conformance project should be used Signed-off-by: Jussi Kukkonen <[email protected]>
3f49d7d
to
0b85ed5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Pull Request Test Coverage Report for Build 9894255152Details
💛 - Coveralls |
There is no automated way to run he conformance test suite locally (using your local python-tuf version) but we could potentially add something into tox... it will need a bit of thinking though. It's not too difficult manually, something like this should work:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool. Tried it locally and it worked nicely. Does the action also work with tuf-confromance@main
? AFAICS you tried it against a patched action?
https://github.com/jku/python-tuf/actions/runs/9874869528
.github/workflows/conformance.yml
Outdated
conformance: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout the client wrapper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: We don't call it wrapper elsewhere here. IMO calling it conformance client would be clearer.
Yeah I used the patched branch for testing but that branch has since been merged -- main should work right now (obviously it will break at some point so we should start pinning the action as soon as we have something that looks like a release) |
Signed-off-by: Jussi Kukkonen <[email protected]>