-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design improvements - 1 #73
Conversation
These names better reflect the meaning of the objects. Also: Backend implementation of AvatarURL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the first stage of the design overhaul, this looks quite good. There are still several elements that need to be improved, but this can happen in later PRs.
I have only noticed a couple of errors in this PR, which should be fixed before a merge:
- All assets are not loaded because of a
404
error (add-ticket.svg
,invite.svg
,classroom.png
) - Creating and inviting to a conference does not work anymore (Open conference, Invite to conference etc.).
web-gui/src/app/page-components/classroom/classroom.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot one more thing:
These two properties should be added to this class
digital-classroom/web-gui/src/app/page-components/classroom/classroom.component.scss
Line 1 in 4be6b53
.container { |
z-index: 2;
position: relative;
So that the top menu is not displayed under the conference.
Co-authored-by: Max Stephan <[email protected]>
…isters disconnects once a minute.
Co-authored-by: Max Stephan <[email protected]>
The latter is due to your missing .env file to overwrite variables for BBB Backend. |
oh, yes thank you 😄 . I forgot to |
The assets should be served correctly now. |
Part of #55
resolves #19
resolves #62
resolves #60