Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design improvements - 1 #73

Merged
merged 47 commits into from
Oct 13, 2021
Merged

Design improvements - 1 #73

merged 47 commits into from
Oct 13, 2021

Conversation

snicki13
Copy link
Member

@snicki13 snicki13 commented Oct 6, 2021

Part of #55
resolves #19
resolves #62
resolves #60

@snicki13 snicki13 marked this pull request as ready for review October 12, 2021 14:40
@snicki13 snicki13 enabled auto-merge (squash) October 12, 2021 14:40
Copy link
Member

@mxsph mxsph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the first stage of the design overhaul, this looks quite good. There are still several elements that need to be improved, but this can happen in later PRs.

I have only noticed a couple of errors in this PR, which should be fixed before a merge:

  • All assets are not loaded because of a 404 error (add-ticket.svg, invite.svg, classroom.png)
  • Creating and inviting to a conference does not work anymore (Open conference, Invite to conference etc.).

web-gui/src/index.html Outdated Show resolved Hide resolved
web-gui/src/app/util/time-formatter.service.ts Outdated Show resolved Hide resolved
@mxsph mxsph mentioned this pull request Oct 12, 2021
11 tasks
Copy link
Member

@mxsph mxsph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot one more thing:

These two properties should be added to this class

z-index: 2;
position: relative;

So that the top menu is not displayed under the conference.

image

@snicki13
Copy link
Member Author

For the first stage of the design overhaul, this looks quite good. There are still several elements that need to be improved, but this can happen in later PRs.

I have only noticed a couple of errors in this PR, which should be fixed before a merge:

* All assets are not loaded because of a `404` error (`add-ticket.svg`, `invite.svg`, `classroom.png`)

* Creating and inviting to a conference does not work anymore (Open conference, Invite to conference etc.).

The latter is due to your missing .env file to overwrite variables for BBB Backend.

@mxsph
Copy link
Member

mxsph commented Oct 12, 2021

The latter is due to your missing .env file to overwrite variables for BBB Backend.

oh, yes thank you 😄 . I forgot to unstash these configurations.

@mxsph mxsph changed the title UI overhaul Design improvements - 1 Oct 12, 2021
@mxsph mxsph disabled auto-merge October 13, 2021 07:57
@mxsph mxsph enabled auto-merge (squash) October 13, 2021 07:58
@snicki13
Copy link
Member Author

The assets should be served correctly now.

@mxsph mxsph merged commit 313cccc into master Oct 13, 2021
@mxsph mxsph deleted the ui-overhaul branch October 13, 2021 16:33
@mxsph mxsph mentioned this pull request Oct 28, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conferece Creation & Leave Button Display / Hide Conferences Avatar upload
2 participants