-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User List UI Component #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far 👍 However, I still have three comments:
-
If you set yourself to invisible it leads to an overflow of the container which in turn leads to a scrollbar being displayed.
-
I would change the icons (possibly the icons from the mockup). Also, I would add tooltips here to describe what the icons do.
-
I would also make these changes to fix overflow errors when a username is very long:
diff --git a/web-gui/src/app/page-components/classroom/ticket-list/ticket/ticket-user-display/ticket-user-display.component.scss b/web-gui/src/app/page-components/classroom/ticket-list/ticket/ticket-user-display/ticket-user-display.component.scss
index 9c71898..afb1c22 100644
--- a/web-gui/src/app/page-components/classroom/ticket-list/ticket/ticket-user-display/ticket-user-display.component.scss
+++ b/web-gui/src/app/page-components/classroom/ticket-list/ticket/ticket-user-display/ticket-user-display.component.scss
@@ -4,7 +4,7 @@
align-items: center;
min-width: 132px;
max-width: 200px;
- height: 38px;
+ min-height: 38px;
.user-avatar {
height: 32px;
margin-right: 5px;
@@ -20,6 +20,7 @@
}
.user-name {
font-size: 16.4px;
+ word-wrap: break-word;
}
}
}
I added the tooltips and hid the overflow.
btw.: I know, that the component structure is somewhat crazy right now. Refactoring will definitely happen. |
We can discuss the icons at the next meeting :) |
This is an UI only PR.
Part of #55