Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Muteable sound for privileged users on new ticket #99

Merged
merged 3 commits into from
Nov 2, 2021
Merged

Muteable sound for privileged users on new ticket #99

merged 3 commits into from
Nov 2, 2021

Conversation

snicki13
Copy link
Member

@snicki13 snicki13 commented Nov 2, 2021 •
edited by mxsph
Loading

resolves #1

@snicki13 snicki13 requested a review from mxsph November 2, 2021 12:59
@snicki13 snicki13 added enhancement New feature or request UI/UX labels Nov 2, 2021
@snicki13 snicki13 enabled auto-merge (squash) November 2, 2021 12:59
@snicki13 snicki13 changed the title Feature/ticket sound Muteable sound for privileged users on new ticket Nov 2, 2021
mxsph
mxsph approved these changes Nov 2, 2021
View reviewed changes
Copy link
Member

@mxsph mxsph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the long term, we should consider saving the user's settings (sound + notification yes/no) so that they do not always have to change them.

@snicki13 snicki13 merged commit 1914eee into master Nov 2, 2021
@snicki13 snicki13 deleted the feature/ticket-sound branch November 2, 2021 13:32
@mxsph mxsph linked an issue Nov 2, 2021 that may be closed by this pull request
Muteable sound for privileged users on new ticket #1
Closed
@mxsph mxsph mentioned this pull request Nov 2, 2021
Closed
@mxsph mxsph added web-gui and removed UI/UX labels Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxsph mxsph mxsph approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request web-gui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Muteable sound for privileged users on new ticket
2 participants
@snicki13 @mxsph