This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't write original file if it wasn't reprocessed
If `only_process` list is not empty, but it doesn't contain `:original` style, original file hasn't been reprocessed and it's not needed to rewrite/reupload it. [fixes #1993] [fixes #2046] [fixes #1804]
- Loading branch information
1 parent
ce22381
commit 1c7d7f6
Showing
2 changed files
with
56 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c7d7f6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tute This commit broke support for passing proc inside
only_process
option.I'm not sure if it is officially supported, but here it is
paperclip/lib/paperclip/attachment.rb
Line 215 in 544fa14
1c7d7f6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it is https://github.com/thoughtbot/paperclip/blob/master/spec/paperclip/attachment_spec.rb#L487-L497
1c7d7f6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aha! Thank you. Why didn't that spec fail?
1c7d7f6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's buggy inside
save
method which is not called in this test1c7d7f6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be willing to modify or add a regression test, and fix the bug? Thanks so much!