Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Rails 8.0 #1239

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add support for Rails 8.0 #1239

wants to merge 5 commits into from

Conversation

nickcharlton
Copy link
Member

Here, we loosen the constraints to allow us to use Rails 8.0, and update the dummy app so that we're testing against Rails 8.0.

Closes #1213.

We were getting an incompatibility with the version otherwise being
fetched. By requiring a more recent version, we avoid a bundling issue.

    can't activate sqlite3 (>= 2.1), already activated sqlite3-1.7.3-arm64-darwin
This was the state after running, and accepting most of the new changes:

    D test/dummy/app/assets/stylesheets/application.css
    M test/dummy/bin/setup
    M  test/dummy/config/boot.rb
    M test/dummy/config/environments/development.rb
    M test/dummy/config/environments/production.rb
    M test/dummy/config/environments/test.rb
    M test/dummy/config/initializers/filter_parameter_logging.rb
    M test/dummy/config/puma.rb
    M test/dummy/public/404.html
    M test/dummy/public/422.html
    M test/dummy/public/500.html
    ?? test/dummy/bin/dev
    ?? test/dummy/bin/rubocop
    ?? test/dummy/bin/thrust
    ?? test/dummy/config/initializers/new_framework_defaults_8_0.rb
    ?? test/dummy/db/migrate/20241129142620_add_service_name_to_active_storage_blobs.active_storage.rb
    ?? test/dummy/db/migrate/20241129142621_create_active_storage_variant_records.active_storage.rb
    ?? test/dummy/db/migrate/20241129142622_remove_not_null_on_active_storage_blobs_checksum.active_storage.rb
    ?? test/dummy/public/400.html
    ?? test/dummy/public/406-unsupported-browser.html
    ?? test/dummy/public/icon.png
    ?? test/dummy/public/icon.svg
    ?? test/dummy/public/robots.txt
To be able to run the tests, we need to run migrations. To run
migrations, we need to be able to refer to the dummy app's Rake tasks.

This adds them into the `Rakefile` to we can do that.

https://github.com/thoughtbot/administrate/blob/main/Rakefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare for Rails 8
1 participant