Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Rails 8 applications generate duplicate CI files #1243

Open
Tracked by #1213
stevepolitodesign opened this issue Dec 5, 2024 · 4 comments
Open
Tracked by #1213

New Rails 8 applications generate duplicate CI files #1243

stevepolitodesign opened this issue Dec 5, 2024 · 4 comments

Comments

@stevepolitodesign
Copy link
Contributor

Relates to #1213

We create files that end in .yaml, and Rails created files that end in .yml

template "ci.yml", ".github/workflows/ci.yaml"
template "dependabot.yml", ".github/dependabot.yaml"

@stevepolitodesign stevepolitodesign changed the title New Rails 8 applications generate two CI files New Rails 8 applications generate duplicate CI files Dec 5, 2024
@stevepolitodesign
Copy link
Contributor Author

I think we can rely on the dependabot.yml file generated by Rails, but need to replace the ci.yml file generated by Rails.

@nickcharlton
Copy link
Member

Oh yeah, weird. I thought I always used the longer form, but I seem to use the three letter variant.

I also prefer to use either main.yml or tests.yml instead of ci.yml for the name. My thinking here is that "CI" is meaningless in this context, all the files are "CI" as we've come to understand that term.

Then I'll have different files so that we break out the feedback you get on the GitHub statuses view:

  • tests
  • linting
  • bundle audit
  • etc

@stevepolitodesign
Copy link
Contributor Author

We could call --skip-ci when running rails new to make it simpler for use to maintain these files.

I also prefer to use either main.yml or tests.yml instead of ci.yml for the name. My thinking here is that "CI" is meaningless in this context, all the files are "CI" as we've come to understand that term.

Then I'll have different files so that we break out the feedback you get on the GitHub statuses view:

It looks like having one file will still break out each task into its own status. Below is a screenshot from a personal project that is using the stock CI file from Rails.

CleanShot 2024-12-06 at 09 27 23

@nickcharlton
Copy link
Member

Yeah, I'd expect it break things out like that. Much of my intention from breaking out the files is to not have horribly long YAML files which are tricky to understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants