Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of magic number "-99999" in bias objective function #90

Closed
havanagrawal opened this issue Jan 25, 2018 · 2 comments
Closed

Use of magic number "-99999" in bias objective function #90

havanagrawal opened this issue Jan 25, 2018 · 2 comments

Comments

@havanagrawal
Copy link
Contributor

There is a section in the objectivefunction.py file in the bias function:

if evaluation[i] == -99999:
    '''
    Cleans out No Data values
    '''
    logging.warning('Wrong Results! Clean out No Data Values')
    pass

I don't understand why this value of -99999 is being used. I couldn't find this number anywhere else in the repository, and similar functions (such as pbias) do not do this.

Perhaps I am missing a particular data point, but it looks like this check is redundant, and perhaps can be removed.

@thouska
Copy link
Owner

thouska commented Jan 25, 2018

This is not necessary anymore and coul be replaced with a filter for all objectivefunctions as requested in #79

@thouska
Copy link
Owner

thouska commented Jan 29, 2018

Solved

@thouska thouska closed this as completed Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants