Bitfinex: Fix WS trade processing #1754
Open
+196
−203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add handling for funding trades Fixes thrasher-corp#1746
gbjk
force-pushed
the
bugfix/bitfinex_ws_trade
branch
2 times, most recently
from
0dd865c to
cb416cc
Compare
shazbert
requested changes
Dec 27, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1754 +/- ##
==========================================
+ Coverage 37.13% 37.37% +0.23%
==========================================
Files 414 415 +1
Lines 180198 178586 -1612
==========================================
- Hits 66925 66746 -179
+ Misses 105413 104042 -1371
+ Partials 7860 7798 -62
|
shazbert
requested changes
Dec 28, 2024
4 tasks
It's been a year, and I'm still getting caught out by govet demanding I don't shadow a var I was deliberately shadowing. Made worse by an increase in clashes with stylecheck when they both want opposite things on the same line.
gbjk
force-pushed
the
bugfix/bitfinex_ws_trade
branch
from
48ebaf7 to
f86fff4
Compare
gloriousCode
requested changes
Jan 7, 2025
| @@ -1382,17 +1372,44 @@ func TestWsOrderBook(t *testing.T) { | |||
| assert.ErrorIs(t, err, errNoSeqNo, "handleWSBookUpdate should send correct error") | |||
| } | |||
|
|
|||
| func TestWsTradeResponse(t *testing.T) { | |||
| func TestWSAllTrades(t *testing.T) { | |||
| data, ok := d[2].([]interface{}) | ||
| if !ok { | ||
| return errors.New("trade data type assertion error") | ||
| var wsTrades []*wsTrade |
There was a problem hiding this comment.
Please change this shadowed var name/the original string var name
Comment on lines
+938
to
+939
| if valueType != jsonparser.Array { | ||
| errs = common.AppendError(errs, fmt.Errorf("%w `tradesSnapshot[1][*]`: %w `%s`", errParsingWSField, jsonparser.UnknownValueTypeError, valueType)) |
There was a problem hiding this comment.
This is a little bit extra given that there is only one caller to this and its behind a gate checking if its an array. I am normally one for all checks should be within the function, but its that you just checked to get to this function
There was a problem hiding this comment.
How about this simplification?
func (b *Bitfinex) handleWSPublicTradesSnapshot(respRaw []byte) ([]*wsTrade, error) {
var trades []*wsTrade
err := json.Unmarshal(respRaw, &trades)
return trades, err
}Where handleWSAllTrades changes with:
k, valueType, _, err := jsonparser.Get(respRaw, "[1]")
...
if wsTrades, err = b.handleWSPublicTradesSnapshot(k); err != nil {A lot less tangling of additional jsonparser functions, with added bonus of naked return removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exchange Bitfinex websocket error - unhandled WS trade update event:TestWsinstead ofTestWSFixes #1746
Progresses #1323 with a prototype
Type of change