Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base.SetConfigPairs should not change config formats #1748

Open
gbjk opened this issue Dec 13, 2024 · 0 comments
Open

base.SetConfigPairs should not change config formats #1748

gbjk opened this issue Dec 13, 2024 · 0 comments
Assignees
@gbjk
Labels
low priority This enhancement or update will be implemented at a later date.

Comments

@gbjk
Copy link
Collaborator

gbjk commented Dec 13, 2024

See this code

Way outside the responsibility of this function to set config from exchange.

This might fall into a wide rewrite of the clarity of config defaults and immutability of config vs runtime settings, but if not, this should yield this responsibility to SetCurrencyPairFormat.

Probably Dyno it well before then though.
@gbjk gbjk added the low priority This enhancement or update will be implemented at a later date. label Dec 13, 2024
@gbjk gbjk self-assigned this Dec 13, 2024
@gbjk gbjk moved this to To Do in GoCryptoTrader Kanban Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbjk gbjk

Labels
low priority This enhancement or update will be implemented at a later date.
Projects
GoCryptoTrader Kanban
Status: To Do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gbjk