Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable linting in CI, and add frontend build step in validate #844

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Enable linting in CI, and add frontend build step in validate #844

merged 2 commits into from
Jan 31, 2025

Conversation

rwood-moz
Copy link
Contributor

@rwood-moz rwood-moz commented Jan 29, 2025 •
edited
Loading

This PR does a few things:

  • Adds a frontend ESLINT npm run lint linting step in the GHA frontend validation
  • Adds a backend ruff check linting step in the GHA backend validation
  • Adds a frontend build step (npm run build) during the frontend GHA validation as previously the frontend tests were run but no actual build was done, so build errors were not caught

Note: Once this lands, the GHA validate job will start failing if there are linting errors. Therefore my other PRs must land first (which fix existing lint errors): #836 and #843.

This was linked to issues Jan 29, 2025
Enable linting in CI #838
Closed
Have frontend validate GHA do a build #842
Closed
@rwood-moz rwood-moz added the testing Issues specific to automated testing label Jan 29, 2025
@rwood-moz rwood-moz force-pushed the testing/enable-ci-linting branch from 07b51fa to c54b8ea Compare January 29, 2025 17:04
@rwood-moz rwood-moz force-pushed the testing/enable-ci-linting branch from c54b8ea to 3c75749 Compare January 29, 2025 17:09
@rwood-moz
Copy link
Contributor Author

rwood-moz commented Jan 29, 2025 •
edited
Loading

I tested this out via GHA associated with this PR and I verified that:

  • Backend and frontend linting checks run as part of GHA validate workflow
  • If linting errors are found the GHA step/workflow will be marked as failed
  • A frontend build is now done as part of the GHA validate workflow
  • If the frontend build fails the GHA step/workflow will be marked as failed

If you want to have a closer look at these changes running in CI:

@rwood-moz rwood-moz force-pushed the testing/enable-ci-linting branch from 3c75749 to 2412122 Compare January 31, 2025 16:16
@rwood-moz rwood-moz marked this pull request as ready for review January 31, 2025 16:19
devmount
devmount approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@devmount devmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Just need to keep in mind to run the linter on my PRs when this landed 😂
Thanks!

@rwood-moz rwood-moz force-pushed the testing/enable-ci-linting branch from 39b9791 to 0bf2cf4 Compare January 31, 2025 16:47
@rwood-moz rwood-moz merged commit 4677448 into main Jan 31, 2025
4 checks passed
@rwood-moz rwood-moz deleted the testing/enable-ci-linting branch January 31, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devmount devmount devmount approved these changes

@aaspinwall aaspinwall aaspinwall left review comments

Assignees
No one assigned
Labels
testing Issues specific to automated testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have frontend validate GHA do a build Enable linting in CI
3 participants
@rwood-moz @devmount @aaspinwall