Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a Pre-Exisiting Installation ID #17

Closed
NickLiffen opened this issue Apr 20, 2021 · 0 comments · Fixed by #26
Closed

Provide a Pre-Exisiting Installation ID #17

NickLiffen opened this issue Apr 20, 2021 · 0 comments · Fixed by #26

Comments

@NickLiffen
Copy link

@tibdex 👋

Would you be open to a pull request that adds the capability to provide a pre-existing Installation ID? 🤔

the majority of this GitHub Action does what we need, however, we have a use case where we just need a create a JWT from a pre-installed GitHub App, vs creating a new "installation".

We could keep installationID optional? Would love your thoughts? 💯

Also open to creating a few unit tests if you're interested 👍 Something like this. I think I can make it work so it would just be a "minor" release, e.g. new feature 👍

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant