-
-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): add collapseToolbar support #1360
Conversation
Alloy/commands/compile/parsers/Ti.UI.Android.CollapseToolbar._ProxyProperty.js
Show resolved
Hide resolved
my local tests are failing for the the (ios, testing/ALOY-983/) popover test. It always says
but I've added both in: Edit: |
Hmm yeah it works for me too, are you running the tests on Linux? CI runs on mac and so do I so maybe there's something there? |
Sorry for the late reply. I'll put it on my todo list to fix the test. Just don't understand why it doesn't list both parents for me 🤷 |
🤦 fixed my tests! All green 👍 |
Ahh that explains why it worked for me as I tend to have alloy installed via |
# [2.1.0](2.0.2...2.1.0) (2024-01-09) ### Bug Fixes * **all:** remove getter in PickerColumn parser ([f916130](f916130)) * missing includes ([819d114](819d114)) ### Features * **all:** update packages ([1837254](1837254)) * **android:** add collapseToolbar support ([#1360](#1360)) ([c3f5e95](c3f5e95)) * update momentjs ([#1358](#1358)) ([100ff29](100ff29)) * update underscore to version 1.13.6 ([36b2fc8](36b2fc8))
CollapseToolbar
to Alloy (copied over fromDrawerLayout
)needed for tidev/titanium-sdk#13760