Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure boxplot key can be drawn without params #6192

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Ensure boxplot key can be drawn without params #6192

merged 4 commits into from
Jan 27, 2025

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #6191.

Briefly, this PR adds a missing value for the staplewidth parameter in draw_key_boxplot().
Also added test to prevent silent breakages of keys in the future.

@teunbrand teunbrand mentioned this pull request Nov 20, 2024
Closed
@teunbrand teunbrand mentioned this pull request Jan 22, 2025
Draft
thomasp85
thomasp85 approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit 5964f7a into tidyverse:main Jan 27, 2025
13 checks passed
@teunbrand teunbrand deleted the fix_6191 branch January 27, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: layer(geom = "boxplot",...) produces error
2 participants
@teunbrand @thomasp85