Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BladeCompiler Error #462

Closed
dpritchard opened this issue Apr 29, 2020 · 1 comment · Fixed by #463
Closed

BladeCompiler Error #462

dpritchard opened this issue Apr 29, 2020 · 1 comment · Fixed by #463

Comments

@dpritchard
Copy link

Apologies if this is not the right place, but it looks like a recent change has broken Jigsaw (at least for new users like me stepping through the installation for the first time).

Issue

The error arises when building the site. The general gist of it is:

Uncaught TypeError: Argument 1 passed to
Illuminate\View\Compilers\ComponentTagCompiler::__construct() must be of the type 
array, object given

Steps to reproduce (on v. 1.3.25):

mkdir my-site
cd my-site
composer require tightenco/jigsaw
./vendor/bin/jigsaw init
./vendor/bin/jigsaw build

Solution?

The issue seems to stem from #460 and line 23 of src/View/BladeCompiler.php specifically.

return (new ComponentTagCompiler(
  $this, $this->classComponentAliases
))->compile($value);

At least in my local version, if I reverse the order of the arguments to new ComponentTagCompiler(...), things seems to build OK.

return (new ComponentTagCompiler(
  $this->classComponentAliases, $this
))->compile($value);

Please let me know if more information or a PR is required.

@damiani
Copy link
Contributor

damiani commented Apr 29, 2020

Thanks @dpritchard, this should be fixed now in v1.3.26!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants