-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[to #464] add unit tests for exported API of RawKVClient #471
[to #464] add unit tests for exported API of RawKVClient #471
Conversation
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@iosmanthus you can solve the issues in another pull request
@marsishandsome PTAL |
Codecov Report
@@ Coverage Diff @@
## master #471 +/- ##
============================================
+ Coverage 32.59% 32.94% +0.35%
- Complexity 1324 1329 +5
============================================
Files 270 270
Lines 17054 17054
Branches 1950 1950
============================================
+ Hits 5559 5619 +60
+ Misses 10889 10829 -60
Partials 606 606
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@iosmanthus please resolve conflicts. |
…it-tests-for-rawkv-client Signed-off-by: iosmanthus <[email protected]>
6913f87
@zz-jason @marsishandsome PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: iosmanthus [email protected]
What problem does this PR solve?
Issue Number: to #464
Problem Description:
Some of the exported API of
RawKVClient
is not covered by unit tests and this blocks the compatibility tests. This pull request add more tests to cover these APIs including:Check List for Tests
This PR has been tested by at least one of the following methods: