-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[to #656] Fix scan with lock #670
Conversation
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Codecov ReportBase: 36.81% // Head: 37.32% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #670 +/- ##
============================================
+ Coverage 36.81% 37.32% +0.51%
- Complexity 1536 1572 +36
============================================
Files 278 278
Lines 17386 17386
Branches 1976 1978 +2
============================================
+ Hits 6400 6489 +89
+ Misses 10335 10241 -94
- Partials 651 656 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
pingcap/tispark#2089 |
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
} | ||
if (!locks.isEmpty()) { | ||
ResolveLockResult resolveLockResult = | ||
lockResolverClient.resolveLocks(backOffer, version, locks, forWrite); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just resolve the first lock like this : https://github.com/pingcap/tispark/blob/d9afb8c5b33aed8efc9a2914a24b7e85708aca61/tikv-client/src/main/java/com/pingcap/tikv/operation/KVErrorHandler.java#L153
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why ?
It seems that resolve multiple locks at a time should be more efficient. For example, we get the maximum TTL here and just wait for the longest one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. LGTM
@shiyuhang0, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. You are not a reviewer or committer or co-leader or leader. |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-3.3 in PR #697 |
Signed-off-by: ti-srebot <[email protected]> Signed-off-by: ti-srebot <[email protected]> Co-authored-by: Ping Yu <[email protected]>
Signed-off-by: shiyuhang <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: ti-srebot <[email protected]> Signed-off-by: ti-srebot <[email protected]> Co-authored-by: Ping Yu <[email protected]>
What problem does this PR solve?
Issue Number: close #656
Problem Description: Catalog get table API return null sometimes
What is changed and how does it work?
Add
resolve locks
toscan
implementation.See the issue analysis here.
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
scan
Related changes