Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sock_connect vs. timeout? #42

Open
blokhin opened this issue Dec 7, 2023 · 1 comment
Open

sock_connect vs. timeout? #42

blokhin opened this issue Dec 7, 2023 · 1 comment
Assignees
@knopki
Labels
documentation Improvements or additions to documentation question Further information is requested

Comments

@blokhin
Copy link
Member

blokhin commented Dec 7, 2023

Documented in https://docs.aiohttp.org/en/stable/client_reference.html, sock_connect is set to 10 minutes, which might be too much:

metis-client/metis_client/client.py

Line 238 in 00639fa

es_timeout = ClientTimeout(total=timeout, sock_connect=600, sock_read=None)

How is it related to a general client timeout?
@blokhin blokhin added documentation Improvements or additions to documentation question Further information is requested labels Dec 7, 2023
@knopki
Copy link
Member

knopki commented Dec 7, 2023

Related issues: rtfol/aiohttp-sse-client#2 and rtfol/aiohttp-sse-client#161

These are timeouts for SSE stream, and general client's timeout is not applied here.
timeout and sock_read should be None's or stream will be terminated. Not sure about sock_connect... maybe None is fine too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knopki knopki

Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blokhin @knopki