-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build fails in WSL (Ubuntu 22.04) using clang18 #849
Comments
I want to know if this is because the higher version of clang, or there are something wrong in my comfiguration. |
edit v1: This is already on the roadmap, so if you don't have time to do it, I will pick it up later. The warning you encountered is due to a new compiler check introduced in clang-18. do you have time to contribute? To enable clang-18, we need to address the compiler warning and update the version in the CI workflow. This is already on the roadmap, so if you don't have time to do it, I will pick it up later. steps to resolve the compiler warning:
no_warning(weak-vtables)
no_warning(thread-safety-negative) # experimental flag, too many false positives
no_warning(enum-constexpr-conversion) # breaks magic-enum library in clang-16
no_warning(unsafe-buffer-usage) # too aggressive
++ no_warning(switch-default) # conflicts with "defaults in a switch covering all enum values"
# TODO Enable conversion, sign-conversion, double-promotion warnings.
endif () This is a CMake trick to disable warnings. but, some warnings can be useful. [submodule "contrib/datasketches-cpp"]
path = contrib/datasketches-cpp
-- url = https://github.com/ClickHouse-Extras/datasketches-cpp.git
++ url = https://github.com/apache/datasketches-cpp.git
|
After adding
So, |
let's add together |
These can also be solved by adding
so we should add |
@what-is-me |
What's Wrong
I have recently tried to clean build proton with clang18 in WSL (Ubuntu 22.04), but it reports
error: 'switch' missing 'default' label [-Werror,-Wswitch-default]
in base/base/StringRef.h:155:5.cmake args are copied from
build.sh
The text was updated successfully, but these errors were encountered: