-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the problem of map(low_cardinality) and tuple(low_cardinality) #51
Merged
Jasmine-ge
merged 4 commits into
main
from
bugfix/issue-50-nested-type-lowcardinality-problem
Jul 31, 2024
Merged
Fix the problem of map(low_cardinality) and tuple(low_cardinality) #51
Jasmine-ge
merged 4 commits into
main
from
bugfix/issue-50-nested-type-lowcardinality-problem
Jul 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need revisit the interfaces: /// only write column data
void Column::flushToSerializer()
{
serializeBinaryBulkPrefix();
serializeBinaryBulk();
serializeBinaryBulkSuffix();
}
/// only read column data
Object[] DataType::readFromDeserializer()
{
deserializeBinaryBulkPrefix();
deserializeBinaryBulk();
deserializeBinaryBulkSuffix();
}
/// write a column
serializer.writeUTF8StringBinary(column.name);
serializer.writeUTF8StringBinary(column.type.name());
column.flushToSerializer(serializer, true);
/// read a column:
String name = deserializer.readUTF8StringBinary();
String type = deserializer.readUTF8StringBinary();
IDataType dataType = DataTypeFactory.get(type, serverContext);
Object[] arr = dataType.readFromDeserializer(rowCnt, deserializer);
column = ColumnFactory.createColumn(name, dataType, arr); |
yl-lisen
reviewed
Jul 30, 2024
timeplus-native-jdbc/src/main/java/com/timeplus/data/Column.java
Outdated
Show resolved
Hide resolved
yl-lisen
reviewed
Jul 30, 2024
timeplus-native-jdbc/src/main/java/com/timeplus/data/Column.java
Outdated
Show resolved
Hide resolved
yl-lisen
reviewed
Jul 30, 2024
timeplus-native-jdbc/src/main/java/com/timeplus/data/ColumnLowCardinality.java
Outdated
Show resolved
Hide resolved
yl-lisen
reviewed
Jul 30, 2024
timeplus-native-jdbc/src/main/java/com/timeplus/data/ColumnLowCardinality.java
Outdated
Show resolved
Hide resolved
yl-lisen
reviewed
Jul 30, 2024
timeplus-native-jdbc/src/main/java/com/timeplus/data/ColumnLowCardinality.java
Outdated
Show resolved
Hide resolved
yl-lisen
reviewed
Jul 30, 2024
timeplus-native-jdbc/src/main/java/com/timeplus/data/ColumnMap.java
Outdated
Show resolved
Hide resolved
yl-lisen
reviewed
Jul 30, 2024
timeplus-native-jdbc/src/main/java/com/timeplus/data/ColumnMap.java
Outdated
Show resolved
Hide resolved
yl-lisen
reviewed
Jul 30, 2024
timeplus-native-jdbc/src/main/java/com/timeplus/data/ColumnNullable.java
Outdated
Show resolved
Hide resolved
yl-lisen
reviewed
Jul 30, 2024
timeplus-native-jdbc/src/main/java/com/timeplus/data/ColumnTuple.java
Outdated
Show resolved
Hide resolved
yl-lisen
reviewed
Jul 30, 2024
timeplus-native-jdbc/src/main/java/com/timeplus/data/ColumnTuple.java
Outdated
Show resolved
Hide resolved
yl-lisen
reviewed
Jul 30, 2024
timeplus-native-jdbc/src/main/java/com/timeplus/data/ColumnTuple.java
Outdated
Show resolved
Hide resolved
yl-lisen
reviewed
Jul 30, 2024
timeplus-native-jdbc/src/main/java/com/timeplus/data/IColumn.java
Outdated
Show resolved
Hide resolved
yl-lisen
reviewed
Jul 30, 2024
timeplus-native-jdbc/src/main/java/com/timeplus/data/type/DataTypeBool.java
Outdated
Show resolved
Hide resolved
yl-lisen
reviewed
Jul 30, 2024
timeplus-native-jdbc/src/main/java/com/timeplus/data/type/DataTypeDate.java
Outdated
Show resolved
Hide resolved
Jasmine-ge
force-pushed
the
bugfix/issue-50-nested-type-lowcardinality-problem
branch
from
July 31, 2024 03:21
7157f59
to
4d5379c
Compare
yl-lisen
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some of the existed problems of nested low_cardinality types. close #50