Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-attaching the web component to DOM breaks editor. #5

Open
mstahv opened this issue Dec 8, 2020 · 3 comments
Open

Re-attaching the web component to DOM breaks editor. #5

mstahv opened this issue Dec 8, 2020 · 3 comments

Comments

@mstahv
Copy link

mstahv commented Dec 8, 2020

Steps to reproduce:

  1. Go to https://codepen.io/tinymce/pen/oNLbGwP
  2. Type some text and apply formatting
  3. Select tinymce-editor in the element inspector
  4. Store it in global variable, then remove and add back:
const ed = $0;
document.body.removeChild($0);
document.body.appendChild(ed);

Now the editor is back but the content is not editable and old content is lost.

@web-padawan
Copy link

Looks like the <iframe> becomes empty when re-attaching:

iframe

It could be that this is not the web component specific issue but the bug in TinyMCE itself.

@tiny-james
Copy link
Contributor

Essentially iframes lose all their state when removed from the DOM. With iframes that reference a URL this just means that they reload the URL but in the case of TinyMCE the iframe is used to store the content, separate CSS from the rest of the page and allow for a separate selection model. As TinyMCE does not keep a copy of the HTML being edited outside of the iframe it is unrecoverable if it is removed from the DOM.

The traditional workaround is to call editor.getContent() and store the editor content (and possibly store the selection with editor.selection.getBookmark(3) ) then destroy the existing editor and create a new editor with the content. Sadly this will lose the undo stack as there's no way to extract that from the editor.

In future when we have proper browser support we'd like to implement an inline-like editor in shadow dom which would then be movable however I have heard from the editor team that their experiments have shown that it's currently impossible due to the way browsers implement selection inside a shadow dom.

@web-padawan
Copy link

it's currently impossible due to the way browsers implement selection inside a shadow dom.

Yes, that's a known limitation which affects Safari: window.getSelection() does not return nodes from Shadow DOM.
There is a polyfill which I'm using with Quill but it's unofficial and might have some limitations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants